[Octave-bug-tracker] [bug #45324] optimization/qp.m: allow row vectors for argument q

[Rik]

Follow-up Comment #1, bug #45324 (project octave):

Could you post a changeset, or indicate what you want changed?

The input processing for qp.m is


  if (nargs >= 3)
    q = varargin{1};
  else
    q = [];
  endif


which seems to accept either row or column.  Is 'q' guaranteed to be a vector
(column or row)?  Then it is possible to change to


    q = varargin{1}(:);


which will guarantee a column vector.

I also don't see in the code that we are guaranteeing that x0 is a column
vector.  Does qp really work regardless of the orientation of x0?

It doesn't appear that this multiplication would work correctly if x0 is a row
vector.


    eq_infeasible = (n_eq > 0 && norm (A*x0-b) > rtol*(1+abs (b)));



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45324>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/