[Octave-bug-tracker] [bug #45369] pkg build leads to duplication of PKG_ADD and PKG_DEL files

[Julien Bect]

Follow-up Comment #18, bug #45369 (project octave):

>> 2) Accept PKG_ADD/PKG_DEL files in ./inst, or in any
>> subdirectory of ./inst. Those files are copied at the
>> corresponding location in the arch-independent directory.
>
> Not sure if I understood all the implications of it correctly,
> but I kind of agree. Agree with accepting files in ./inst and
> its subdirectories (seems like pkg() removes non .m files,
> that should not happen). Do not agree on having PKG_ADD on
> subdirectories executed when loading the package. It should
> be the PKG_ADD at the root of inst/ that is responsible for
> calling the others (most likely by adding the subdirectories
> to the path).

I agree: a PKG_ADD in a subdirectory should not be executed automatically. It
is executed if the subdirectory is add to the path, which is typically done by
the parent PKG_ADD.

I also agree that this implies a change in pkg: non-m-files should not be
discarded by pkg (or at least PKG_ADD/PKG_DELL files should not be
discarded).


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45369>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.gnu.org/