[Octave-bug-tracker] [bug #45456] hsv2rgb is very strict about its input values

[Carnë Draug]

Update of bug #45456 (project octave):

                  Status:               Confirmed => Fixed                  
             Open/Closed:                    Open => Closed                 
                 Release:                   4.0.0 => dev                    

    _______________________________________________________

Follow-up Comment #10:

I'm not very fond of adding a specific tolerance. 

I have pushed two changesets, one to relax the tolerance in iscolormap (and
fixed functions that actually needed that intolerance), and another that
rewrites the input checking for hsv2rgb.

As I mentioned below, values of hue outside the range are handled in a special
manner to account for the fact that it's an angle in a cylindrical coordinate
system.  For saturation and brightness, will start to return  garbage.

I also made a few adjustments for performance when converting between classes,
added support for ND images (MxNx3xK), made it return the same class as the
input, and allow sparse (also Matlab compatible).

I understand from your previous patch that other rgb2X and X2rgb may suffer of
similar issue. Would be nice if you could submit a patch.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45456>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/