[Octave-bug-tracker] [bug #45810] zp2sos error when calling cplxpair

[Mike Miller]

Update of bug #45810 (project octave):

                  Status:         Patch Submitted => In Progress            
        Operating System:       Microsoft Windows => Any                    

    _______________________________________________________

Follow-up Comment #9:

I have to make a change to the signal package as well to accommodate the
original bug report, but this fix to cplxpair helps with that.

Rik, do you think this change makes the pairing too lenient? The way I read
the Matlab function help, it makes it sound like the tolerance is done
element-wise rather than based on the max(abs(z)).

The following example shows how this can go wrong:


octave:1> z = [2e6 + j; 2e6 - j; 1e-9 * (1 + j); 1e-9 * (1 - 2j)];
octave:2> cplxpair (z)
ans =

   1.0000e-09 - 2.0000e-09i
   1.0000e-09 + 1.0000e-09i
   2.0000e+06 - 1.0000e+00i
   2.0000e+06 + 1.0000e+00i



If the tolerance were taken from the magnitude of each element, z(3) and z(4)
wouldn't be a valid complex conjugate pair.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?45810>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/