[Octave-bug-tracker] [bug #46084] image package: imcrop() doesn't work any more

[Carnë Draug]

Update of bug #46084 (project octave):

                  Status:               Confirmed => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #5:

Thank you guys for the help.

I have pushed Pantxo's patch
http://hg.code.sf.net/p/octave/image/rev/90f66be4622a to fix the original bug
report. This was pushed to stable.

And I pushed a slightly less verbose version of Avinoam patch to support
clicking on the image in any order
http://hg.code.sf.net/p/octave/image/rev/54c92ed5bf90

Regarding displaying of a message asking the user to click on the corners I
don't like that very much. If the person that will select the region is the
person that wrote the code, then the message is not required, that person
already knows what to do. If it is not the same person, then we should let the
developer choose what best way to inform his users what they have to do in the
(via a message at the prompt, a graphical textbox, or something else). We
should not be cluttering stdout ourselves.  Of course, the ideal situation is
when we have a nice looking interactive cropping tool.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46084>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/