[Octave-bug-tracker] [bug #46444] buttord, cheb1ord, cheb2ord : different errors

[Charles Praplan]

URL:
  <http://savannah.gnu.org/bugs/?46444>

                 Summary: buttord, cheb1ord, cheb2ord : different errors
                 Project: GNU Octave
            Submitted by: charprap
            Submitted on: Sat 14 Nov 2015 01:49:29 PM GMT
                Category: Octave Forge Package
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Incorrect Result
                  Status: None
             Assigned to: None
         Originator Name: Charles Praplan
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 4.0.0
        Operating System: Microsoft Windows

    _______________________________________________________

Details:

The functions buttord, cheb1ord, cheb2ord had different problems
and missing functionalities on which I worked to propose
here corrections. As the corrections are partially the same for
all 3 function, I decided to post only one error report.

I append a zip file with all the necessary files and testcases,
and the diff files.

Below the detailed description of all corrections, each time with
the corresponding test case.

buttord:
=======

1) Error corrected

     The known problem of overdesigning bandpass and bandreject filters
     (displayed as warning by the function) has been solved.

     Test cases: buttord_test_dig_BP.m
                 buttord_test_dig_notch.m

2)Improvements

2.1) Analog filters are now supported as in Matlab.
     (this includes a new 'validate_filter_bandss.m'
     function for analog filters that I already submitted
     in the case of the ellipord function).

     Test cases: buttord_test_ana_LP.m
                 buttord_test_ana_HP.m
                 buttord_test_ana_BP.m
                 buttord_test_ana_notch.m


2.2) New output argument allows to make the filter caracteristic
     touch the passband or stopband corner.

     Test cases: buttord_test_ana_LP.m
                 buttord_test_ana_HP.m
                 buttord_test_ana_BP.m
                 buttord_test_ana_notch.m

                 buttord_test_dig_LP.m
                 buttord_test_dig_HP.m
                 buttord_test_dig_BP.m
                 buttord_test_dig_notch.m


cheb1ord and cheb2ord:
=====================

1) Error corrected

     Solved problem in cheb2ord for band pass filter:
     filter did not satisfy requirements in case of
     NOT symmetrical requirements

     Test cases: buttord_test_dig_BP.m  (fig 5 to 8)

2) Missing functionaly

     Notch filters are now supported

     Test cases: cheb12ord_test_ana_notch.m
                 cheb12ord_test_dig_notch.m

     Test cases: cheb12ord_test_ana_LP.m
                 cheb12ord_test_ana_HP.m
                 cheb12ord_test_ana_BP.m
                 cheb12ord_test_ana_notch.m

                 cheb12ord_test_dig_LP.m
                 cheb12ord_test_dig_HP.m
                 cheb12ord_test_dig_BP.m
                 cheb12ord_test_dig_notch.m

3)Improvements

3.1) Analog filters are now supported as in Matlab.
     (this includes a new 'validate_filter_bandss.m'
     function for analog filters that I already submitted
     in the case of the ellipord function).

     Test cases: cheb12ord_test_ana_LP.m
                 cheb12ord_test_ana_HP.m
                 cheb12ord_test_ana_BP.m
                 cheb12ord_test_ana_notch.m

3.2) New output argument allowing to make the filter caracteristic
     touch the passband or stopband corner.

     Test cases: cheb12ord_test_ana_LP.m
                 cheb12ord_test_ana_HP.m
                 cheb12ord_test_ana_BP.m
                 cheb12ord_test_ana_notch.m

                 cheb12ord_test_dig_LP.m
                 cheb12ord_test_dig_HP.m
                 cheb12ord_test_dig_BP.m
                 cheb12ord_test_dig_notch.m




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 14 Nov 2015 01:49:29 PM GMT  Name: buttord_cheb1ord_cheb2ord.zip 
Size: 26kB   By: charprap

<http://savannah.gnu.org/bugs/download.php?file_id=35457>
-------------------------------------------------------
Date: Sat 14 Nov 2015 01:49:29 PM GMT  Name: buttord.diff  Size: 7kB   By:
charprap

<http://savannah.gnu.org/bugs/download.php?file_id=35458>
-------------------------------------------------------
Date: Sat 14 Nov 2015 01:49:29 PM GMT  Name: cheb1ord.diff  Size: 6kB   By:
charprap

<http://savannah.gnu.org/bugs/download.php?file_id=35459>
-------------------------------------------------------
Date: Sat 14 Nov 2015 01:49:29 PM GMT  Name: cheb2ord.diff  Size: 6kB   By:
charprap

<http://savannah.gnu.org/bugs/download.php?file_id=35460>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46444>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/