[Octave-bug-tracker] [bug #46536] Bad indexing could produce more informative error messages

[Lachlan Andrew]

Follow-up Comment #7, bug #46536 (project octave):

Rik, sorry for being unresponsive -- gmail was treating everything from this
as junk mail, so I didn't notice your update.

The bug was that


 ...::const_iterator field = expr->arg_names ().begin ()


was referring to a transient value, since arg_names() returns by value instead
of reference.  I'm sure I had tested this case (you can see it in the BIST
test as c.fred.foo.bar(-1).), but somehow the transient value must have been
hanging around long enough for the iteration.

I now assign the value to a temporary variable.  Would it be better to return
by (const) reference instead?

Also, thanks for the instructions on writing commit messages.

(file #35738)
    _______________________________________________________

Additional Item Attachment:

File name: bug_46536.v3.cset              Size:5 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46536>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/