octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #44095] readline configuration - tab autocompl


From: John W. Eaton
Subject: [Octave-bug-tracker] [bug #44095] readline configuration - tab autocompletion of paths
Date: Sun, 20 Dec 2015 18:39:21 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 Iceweasel/31.5.3

Follow-up Comment #21, bug #44095 (project octave):

Thanks for working on this feature.

I have a few minor comments:

Please use gnulib::malloc in C++ code.  Or, since we are managing the memory,
use Octave's strsave funtion and operator delete[].

Please use Octave's file_stat class instead of copying functions from gnulib. 
We want to avoid cut and pasted code as much as possible.

In C++ code, please use 0 instead of NULL.

To be consistent with other commit messages, please write the initial line as

description (bug #NNNNN)

instead of "Fixed bug..."

One of my goals for the command_editor class was to use std::string instead of
bare char* pointers where possible for the hook functions and provide wrappers
as needed for interfacing with readline.  For example, look at the way the
quoting/dequoting or completion functions work.  But maybe that isn't really
necessary, I don't know.  In any case, it would be nice to be consistent and
not have a mix of some functions using char* and others std::string.

I know that the term "path" is often used interchangably with "filename" but
I'd prefer to use "path" when describing a list of directory names.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?44095>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]