[Octave-bug-tracker] [bug #46795] dbstop lacks much Matlab functionality

[Lachlan Andrew]

Follow-up Comment #15, bug #46795 (project octave):

Here is the updated patch that fixes some GUI issues.  Torsten, thanks for
removing the restore-breakpoint dialog -- if I had done it, I would have
forgotten the .ui file.

I've also uploaded a draft commit message.  It's rather long, but the patch
touches lots of functions.

I should have mentioned that the patch also fixes some minor bugs with Dan's
marker object, such as several instances of


-          if (markers_mask && (1 << marker::bookmark))
+          if (markers_mask & (1 << marker::bookmark))


and a few lines like


-  if (_edit_area->markersAtLine (line) && (1 << marker::bookmark))
-    line++; // we have a breakpoint here, so start search from next line
+  line++; // Find bookmark strictly after this line.
-verbatim

Should that be a separate patch to keep things clean, or is it OK to lump them
with this one?

Philip, regarding comment #9 -- I don't mind which of you does the final
pushing, but it is great having feedback and testing from both of you.  I
removed the example usage "dbstop in func if cond", as you suggested.  Also, I
can imagine that converting Octave code to Matlab would feel like downgrading;
I always try to keep my code Matlab compatible because I use that at work and
Octave on my notebook, and it is frustrating not being able to += etc.

(file #35944, file #35945)
    _______________________________________________________

Additional Item Attachment:

File name: dbstop_patch_20160108.txt      Size:118 KB
File name: dbstop_commit_message_20160102.txt Size:3 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46795>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/