[Octave-bug-tracker] [bug #46795] dbstop lacks much Matlab functionality

[Lachlan Andrew]

Follow-up Comment #51, bug #46795 (project octave):

Torsten, the problem is that I modified file_in_path to use QMessageBox,
because it would hang from the context in which I called it for inserting
conditional breakpoints.

However, the QMessageBox crashes when called from a callback.  Did your recent
changeset add the callback for handle_request_add_breakpoint to
add_breakpoint_callback?  If so, that would be the conflict.

The attached patch moves the contents of the callback into the caller, and it
no longer crashes.  Do you see a problem with that approach?

It is slightly inelegant that callbacks are used by the other functions like
removing a breakpoint but not for adding one.  A better long-term solution may
be to fix the reason that the old file_in_path would hang.  However, elegance
comes second to not crashing!

(file #36224)
    _______________________________________________________

Additional Item Attachment:

File name: bug_46795.cset                 Size:2 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?46795>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/