[Octave-bug-tracker] [bug #47036] regressions in core m-files due to ismatrix changes

[Colin Macdonald]

Follow-up Comment #13, bug #47036 (project octave):

image/rgb2hsv.m: STILL TODO (perhaps only on stable branch)

plot/draw/contourc.m: ok, could have isnumeric checks added
plot/draw/tetramesh.m: ok, could have isnumeric checks added
plot/draw/shrinkfaces.m: ok, could have isnumeric checks added

geometry/delaunay.m: ok, 2D array test intended.  Note 3D array inputs do in
fact work (via a different code path) but (a) not supported by Matlab and (b)
not documented by us, so I did not add a test for this.  Nor did I prevent
this feature.  These other paths do not do type checking so I didn't add
"isnumeric".

image/gray2ind.m: patch #8903

geometry/inpolygon.m: patch #8903

statistics/tests/hotelling_test.m: ok, 2D array test intended.  No type
checking to be done (other code paths don't do it)

statistics/tests/hotelling_test_2.m: ok, 2D array test intended.  No type
checking to be done (other code paths don't do it)

plot/util/private/__gnuplot_draw_axes__.m: ok, 2D array restriction seems
intended

plot/draw/private/__plt__.m: ok, 2D array restriction is intended

plot/draw/private/__contour__.m: ok, 2D array restriction seems intended

plot/draw/private/__stem__.m: ok, 2D array restriction is intended

    Re: __stem__, I dislike the "if-elseif-end" pattern:


      if (isvector (y))
        x = 1:length (y);
      elseif (ismatrix (y))
        x = 1:rows (y);
      endif


   IMHO, that either should have an else block or a comment
   explaining.  Personally, when I think it can't happen I do:


      else
        error('Tertium non datur')
      endif



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47036>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/