[Octave-bug-tracker] [bug #47232] zip fails if filename has whitespace

[Carnë Draug]

Follow-up Comment #9, bug #47232 (project octave):

The suggested fix of adding quotes to support spaces, will still cause issues
if the filename has quotes.

While system() does not accept a list of arguments to avoid the shell, exec
does.  The following works for me.


-  rootdir = tilde_expand (rootdir);
+  zipfile = make_absolute_filename (zipfile);
+  files = glob (files);
 
-  zipfile = make_absolute_filename (zipfile);
-
-  cmd = sprintf ("zip -r %s %s", zipfile, sprintf (" %s", files{:}));
-
-  origdir = pwd ();
-  cd (rootdir);
-  [status, output] = system (cmd);
-  cd (origdir);
-
-  if (status)
-    error ("zip: zip failed with exit status = %d", status);
+  [pid, msg] = fork ();
+  if (pid < 0)
+    error ("zip: unable to fork in prepartion to call zip");
+  elseif (pid == 0)
+    cd (tilde_expand (rootdir));
+    dup2 (fopen ("/dev/null", "w"), stdout);
+    err = exec ("zip", {"-r", zipfile, files{:}});
+    exit (err);
+  else
+    [pid, status, msg] = waitpid (pid);
+    if (pid < 0)
+      error ("zip: failed to exec zip (exit code %i): %s", status, msg);
+    endif


It has the following issues though:

0 I'm guessing "/dev/null" is not portable
0 when I force exec() to fail, it never exits

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47232>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/