[Octave-bug-tracker] [bug #42006] set (h, "facelighting", "flat") renders dark surfaces/patches

[Pantxo Diribarne]

Follow-up Comment #6, bug #42006 (project octave):

Hi,

I like this patch and the interpretation of the black surface. 

The answer to your question in comments is no, you can't assume the parent of
a patch/surface is an axes, it may also be a hggroup (and actually Octave
doesn't currently have any guards against incorrect parenting, but this is
another bug).

Instead of testing the presence of a light while drawing patches/surfaces, I
find it simpler to declare a private bool property "has_light" that is set
once in "draw_axes_children" (right after the comment "// 1st pass: draw light
objects"). This way you don't have to mess with finding the parent axes (which
BTW you could find using graphics_object::get_ancestor("axes")) for each
patch/surface.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?42006>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/