[Octave-bug-tracker] [bug #47965] psi test tolerance failure on Debian i386

[Mike Miller]

URL:
  <http://savannah.gnu.org/bugs/?47965>

                 Summary: psi test tolerance failure on Debian i386
                 Project: GNU Octave
            Submitted by: mtmiller
            Submitted on: Thu 19 May 2016 11:06:39 AM PDT
                Category: Octave Function
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Inaccurate Result
                  Status: Need Info
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: GNU/Linux

    _______________________________________________________

Details:

Two tests in psi.cc are failing on Debian i386 due to exceeding tolerances. I
can easily increase the tolerance to fix this, but it seems like they were
chosen for a reason. Carnë, ok to double the tolerances on the two tests that
are failing, as shown in the diff below?


diff --git a/libinterp/corefcn/psi.cc b/libinterp/corefcn/psi.cc
--- a/libinterp/corefcn/psi.cc
+++ b/libinterp/corefcn/psi.cc
@@ -179,8 +179,8 @@ can have any value real or complex value
 ## First 6 zeros of the digamma function, in section of 5.1.5 (and also on
 ## Abramowitz and Stegun, page 258, eq 6.3.19)
 %!assert (psi ( 1.46163214496836234126265954232572132846819620400644), 0,
eps)
-%!assert (psi (-0.504083008264455409258269304533302498955385182368579), 0,
eps)
-%!assert (psi (-1.573498473162390458778286043690434612655040859116846), 0,
eps)
+%!assert (psi (-0.504083008264455409258269304533302498955385182368579), 0,
eps*2)
+%!assert (psi (-1.573498473162390458778286043690434612655040859116846), 0,
eps*2)
 %!assert (psi (-2.610720868444144650001537715718724207951074010873480), 0,
eps*10)
 %!assert (psi (-3.635293366436901097839181566946017713948423861193530), 0,
eps*10)
 %!assert (psi (-4.653237761743142441714598151148207363719069416133868), 0,
eps*100)


Here is the test output I am seeing:


***** assert (psi (-0.504083008264455409258269304533302498955385182368579), 0,
eps)
!!!!! test failed
ASSERT errors for:  assert (psi
(-0.504083008264455409258269304533302498955385182368579),0,eps)

  Location  |  Observed  |  Expected  |  Reason
     ()       3.8748e-16       0         Abs err 3.8748e-16 exceeds tol
2.2204e-16
shared variables 
  scalar structure containing the fields:

    em =  0.577215664901533
***** assert (psi (-1.573498473162390458778286043690434612655040859116846), 0,
eps)
!!!!! test failed
ASSERT errors for:  assert (psi
(-1.573498473162390458778286043690434612655040859116846),0,eps)

  Location  |  Observed  |  Expected  |  Reason
     ()       4.3867e-16       0         Abs err 4.3867e-16 exceeds tol
2.2204e-16
shared variables 
  scalar structure containing the fields:

    em =  0.577215664901533





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?47965>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/