[Octave-bug-tracker] [bug #48201] Double click in file explorer does not open png files with default app in windows

[Rik]

Follow-up Comment #8, bug #48201 (project octave):

@Avinoam: To build a debug version with MXE, run the configure script in the
MXE directory with the additional options of


--disable-strip-dist-files --enable-devel-tools


@JohnD: Thanks for testing.  In load-save.cc I see the following code:


// FIXME: looks_like_mat_ascii_file does not check to see
// whether the file contains numbers.  It just skips comments
// and checks for the same number of words on each line.  We
// may need a better check here.  The best way to do that
// might be just to try to read the file and see if it works.

if (looks_like_mat_ascii_file (file, filename))
  retval = LS_MAT_ASCII;


It seems that the original programmer knew this wasn't a great idea.

The code for looks_like_mat_ascii_file is buried in
libinterp/corefcn/ls-mat-ascii.cc.  Sure enough, there is code checking for
'\n' and '\r'.  This isn't very portable.  I wonder if it is possible to go
back to the beginning and open the file in text mode and let the C++ standard
libraries deal with the different endings (CR, LF, CRLF). 


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48201>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/