[Octave-bug-tracker] [bug #48013] Java integration: conversion to double

[Mike Miller]

Update of bug #48013 (project octave):

                 Release:                   4.0.0 => dev                    

    _______________________________________________________

Follow-up Comment #7:

Hi Ernst, thank you for providing a patch to fix this bug.

We really appreciate your contribution, but can you please try to submit small
patches that address one specific change or class of changes? For example each
bullet point that you listed in the commit message of your patch is very
different from the others, implying that they should really be separate
patches. The patch for this bug should consist only of the changes needed to
support the right numeric conversion of Java types. As a reviewer, I spent a
few minutes reading your patch, but got lost in the reformatting changes and
it was not easy to see what parts are needed to fix the bug at hand.

Your new function autoBoxNumber does not follow our coding style conventions,
please try to adhere to those when modifying or submitting new code. See
https://www.gnu.org/software/octave/doc/interpreter/C_002b_002b-Sources.html
and https://www.gnu.org/prep/standards/standards.html#Formatting).

As far as the other changes, you can separate those out and submit additional
patches for things like reorganizing and documenting code, but please try to
stick to our existing coding style conventions. We are unlikely to apply
patches that make some of the whitespace changes that you propose here for
example. And for doxygen markup, I believe we are using the "//!" convention
already in our code base, and please try to avoid embedded HTML markup in the
doxygen markup.

We hope to see continuing contributions from you, as the Java interface code
does not get a lot of attention and does need some work. Please try to rework
this patch into the minimal change needed to address the numeric conversion
bug.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48013>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/