[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #48013] Java integration: conversion to double
From: |
Mike Miller |
Subject: |
[Octave-bug-tracker] [bug #48013] Java integration: conversion to double |
Date: |
Tue, 26 Jul 2016 15:50:54 +0000 (UTC) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Firefox/47.0 |
Update of bug #48013 (project octave):
Status: None => Patch Submitted
_______________________________________________________
Follow-up Comment #9:
Thanks for updating the patch. The name of the function is still not
appropriate, we use snake_case not camelCase. The name of the function sounds
like it is doing the conversion, I would call it something like
"is_auto_convertible_number". The braces and indenting are good now. There
should also be a space before the opening parenthesis of the argument list,
and the return value should be on a separate line. I can fix these small
issues or you can if you want to submit another updated patch.
As to doxygen, there are several files in Octave's code base now that are
using the //! style, and consistency is the most important thing.
Do not use <p> HTML tags to separate paragraphs, just use an empty //! comment
line.
Do not use <code> HTML tags to wrap a single word, use the @c doxygen command.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?48013>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
- [Octave-bug-tracker] [bug #48013] Java integration: conversion to double, Ernst Reissner, 2016/07/17
- [Octave-bug-tracker] [bug #48013] Java integration: conversion to double, Mike Miller, 2016/07/18
- [Octave-bug-tracker] [bug #48013] Java integration: conversion to double, Ernst Reissner, 2016/07/21
- [Octave-bug-tracker] [bug #48013] Java integration: conversion to double, Mike Miller, 2016/07/22
- [Octave-bug-tracker] [bug #48013] Java integration: conversion to double, Ernst Reissner, 2016/07/26
- [Octave-bug-tracker] [bug #48013] Java integration: conversion to double,
Mike Miller <=
- [Octave-bug-tracker] [bug #48013] Java integration: conversion to double, Ernst Reissner, 2016/07/27
- [Octave-bug-tracker] [bug #48013] Java integration: conversion to double, Mike Miller, 2016/07/28
- [Octave-bug-tracker] [bug #48013] Java integration: conversion to double, Mike Miller, 2016/07/28
- [Octave-bug-tracker] [bug #48013] Java integration: conversion to double, Ernst Reissner, 2016/07/28