[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #48640] gzip/bzip errors in destructors will c
From: |
Carnë Draug |
Subject: |
[Octave-bug-tracker] [bug #48640] gzip/bzip errors in destructors will cause Octave to crash |
Date: |
Wed, 27 Jul 2016 15:43:24 +0000 (UTC) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0 |
Follow-up Comment #2, bug #48640 (project octave):
Could you review this change?
https://bitbucket.org/carandraug/octave/commits/e53bd08a19e0868eee2c4237e8212f0a16d468b2?at=bug-48640
I went with the use of a close method instead of warnings since warnings
wouldn't add anything useful. The only error handling this function should do
is skip files that caused errors and not include them in the list of output
files.
I also realized that if the destructor is called as part of exception
handling, we have nothing to do about a new error. So we just do our best to
free any resources. In other cases, then we call close() which would throw as
expected.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?48640>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/