[Octave-bug-tracker] [bug #48753] KeyboardTranslator.h macros failing with Qt5 and GCC 4.8.4

[Mike Miller]

Follow-up Comment #1, bug #48753 (project octave):

This code was pulled in wholecloth from the qterminal project, and it has been
modified only minimally from its origin.

There's nothing particular strange about these macros, they are declared as a
public part of the kdelibs API, and pasted into the qterminal code so that it
doesn't depend on kdelibs.

Looking at the error message, the compiler seems to be having a problem with
the statement


some_var = 0;


where some_var is an instance of a class that has deleted its default
assignment operator, but does have an assignment operator that accepts a
pointer.

Can you try this quick hack to see if it resolves the error on your system?


diff --git a/libgui/qterminal/libqterminal/unix/KeyboardTranslator.h
b/libgui/qterminal/libqterminal/unix/KeyboardTranslator.h
--- a/libgui/qterminal/libqterminal/unix/KeyboardTranslator.h
+++ b/libgui/qterminal/libqterminal/unix/KeyboardTranslator.h
@@ -98,7 +98,7 @@ static struct K_GLOBAL_STATIC_STRUCT_NAM
     {                                                                        
 \
         _k_static_##NAME##_destroyed = true;                                 
 \
         TYPE *x = _k_static_##NAME;                                          
 \
-        _k_static_##NAME = 0;                                                
 \
+        _k_static_##NAME = static_cast<TYPE *> (0);                          
 \
         delete x;                                                            
 \
     }                                                                        
 \
 } NAME;


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48753>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/