[Octave-bug-tracker] [bug #48678] mkoctfile returns linker flags on LFLAGS instead of LDFLAGS

[Carnë Draug]

Follow-up Comment #10, bug #48678 (project octave):

carandraug said:
> [...] therefore "-p" would be the flags that mkoctfile uses. [...] in my
view that includes the flags required by Octave plus whatever the user has set
in the environment if any. 

I thought about this again last night and I'm not so sure if that's the most
obvious behaviour after all.

Mike Miller said:
> Agree with jwe, I think it's important that mkoctfile treats CFLAGS,
CPPFLAGS, CXXFLAGS, LDFLAGS, etc as user variables that can be overridden from
the environment, and default to empty (in the case of LDFLAGS) or to a trivial
default (in the case of CXXFLAGS="-g -O2").
>
> But do we want to append the built-in defaults to the user values and allow
the full set of flags to be exported? Or would that be too confusing? 

Yes, mkoctfile should account for XFLAGS set in the environment but it doesn't
have to echo them back when using "mkoctfile -p".

If mkoctfile is called to make an oct file, then it should use env variables. 
If it is called with "-p", then the user will be handling those flags and it
is up to him to append any environment variables that it sees fit, and it will
be up to him to ignore the environment variables as well. pkg-config also does
this, it returns only the flags required and ignores environment variables.

But then the purpose of "mkoctfile -p" overlaps with the purpose of
"octave-config" and the newly reported bug about supporting pkg-config.  So
why do we even need "mkoctfile -p"?

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48678>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/