octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #48828] uigetfile issues


From: Philip Nienhuis
Subject: [Octave-bug-tracker] [bug #48828] uigetfile issues
Date: Fri, 19 Aug 2016 14:59:44 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40

URL:
  <http://savannah.gnu.org/bugs/?48828>

                 Summary: uigetfile issues
                 Project: GNU Octave
            Submitted by: philipnienhuis
            Submitted on: Fri 19 Aug 2016 04:59:41 PM CEST
                Category: Octave Function
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Incorrect Result
                  Status: None
             Assigned to: philipnienhuis
         Originator Name: Philip Nienhuis
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: Any

    _______________________________________________________

Details:

Unlike Matlab, uigetfile does not allow a subdirectory name as input argument.
When trying anyway, a first bug pops up:

>> [a, b, c] = uigetfile ('c:\users')
error: 'retval' undefined near line 66 column 18
error: called from
    __file_filter__ at line 66 column 42
    uigetfile at line 99 column 33


(Above on Windows but similar on Linux)
That is due to a type on scripts/gui/private/__file-filter__.m

Fixing that and trying again, the next bug pops up:

>> [a, b, c] = uigetfile ('c:\users')
error: retval(1,_): but retval has size 0x0
error: called from
    __file_filter__ at line 66 column 42
    uigetfile at line 99 column 33


due to not checking for empty retval before indexing it.

When all this has been fixed uigetfile can also use directory names of path
names as input arg. I'll attach a cset as soon as I have the bug number.

Unlike Matlab, whose docs mention that directory names should end with a
filesep, I didn't bother to check for that in the patch. If no trailing
filesep is present uigetfile displays the parent dir with the lowest dir (to
the right of the rightmost filesep) highlighted (if present) or nothing
highlighted if no match is found.





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48828>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]