octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #49600] Error in the unwind_protect_cleanup se


From: Rik
Subject: [Octave-bug-tracker] [bug #49600] Error in the unwind_protect_cleanup section of print.m
Date: Wed, 16 Nov 2016 18:35:33 +0000 (UTC)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:43.0) Gecko/20100101 Firefox/43.0

Update of bug #49600 (project octave):

                  Status:         Patch Submitted => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #4:

I pushed Pantxo's cset here
(http://hg.savannah.gnu.org/hgweb/octave/rev/219c70d2ba28).  I made two small
changes.

Change #1 : indexing is faster than deleting


    hobj(strncmp (get (hobj, "type"), "ui", 2)) = [];

=>

    hobj = hobj(! strncmp (get (hobj, "type"), "ui", 2));


Change #2 : No need to repeat file name in commit message when multiple things
were done to it.



* print.m: initialize nfig variable at the beginning of the unwind_protect
block
* print.m: remove ui* objects from the list of axes children 
* print.m: consistently use "end" keyword to index prop array 
* print.m: increment nfig after each "set" operation on "units" properties

=>

* print.m: Initialize nfig variable at beginning of the unwind_protect block.
Remove ui* objects from the list of axes children.
Consistently use "end" keyword to index prop array.
Increment nfig after each "set" operation on "units" properties.





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?49600>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]