[Octave-bug-tracker] [bug #49767] publish.tst failure when OSMesa excluded from build

[Dan Sebald]

Follow-up Comment #8, bug #49767 (project octave):

graphics_toolkit("gnuplot") error will lead to a FAIL, though, won't it?

I've looked through the __run_test_suite__.m/test.m code to see when a skip
occurs.  It seems to use the __have_feature__ function itself.  I assume there
is some way of specifying the feature(s?) that is(are) required.

I also noticed that "GNUPLOT" is in the list of, not features, but build
environment variables:


octave:10> __octave_config_info__
[snip]
        GLPK_LIBS = -lglpk
        GNUPLOT = gnuplot
        HDF5_CPPFLAGS = 


I wonder if we could add a new feature variable (the list appears after the
environment variable list) called 

GNUPLOT_AT_BUILD = 1

since Octave is already obviously testing for gnuplot.  We can't say GNUPLOT
is a feature because the system on which Octave is eventually installed may be
different from build and there's a possibility that gnuplot isn't installed
there.

But, GNUPLOT_AT_BUILD is useful because it tells us if gnuplot can be used for
build purposes, e.g., generating plots for documentation.

With that distinction, rather than do the run-time test:


+%!   if (ispc () || ! __have_feature__ ("OSMESA"))
 %!     graphics_toolkit ("gnuplot");
 %!   endif


the publish.tst scripts could be expanded to run the included tests for both
OSMESA present and for GNUPLOT_AT_BUILD present.  That is,

% HOWEVER OSMESA IS SPECIFIED FOR test.m
function publish_osmesa()
    pubtest('fltk');
end

% HOWEVER GNUPLOT_AT_BUILD IS SPECIFIED FOR test.m
function publish_osmesa()
    pubtest('gnuplot');
end

function pubtest(toolkit)
    graphics_toolkit(toolkit);
    % The two tests go here
end

whatever combination of new files, etc. are required to make that work.  Then
there would be four possible tests, e.g., if OSMesa is not available at build:
 2 PASS and 2 SKIP


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?49767>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/