[Octave-bug-tracker] [bug #50122] image package: normxcorr2 sometimes returns inf values

[Mike Miller]

Update of bug #50122 (project octave):

                  Status:                    None => Patch Submitted        

    _______________________________________________________

Follow-up Comment #3:

Hartmut - you could combine your change into one line, may be slightly more
efficient since it will be assigning the zeros all at the same time:


c(isinf (c) | isnan (c)) = 0;


You could also change the test to assert that c is exactly what you expect it
to be, something like


%! assert (c, [-1 -.5 0 1 -1/sqrt(13) -.5], eps)


or at least test that c(3) is exactly zero. Just my two cents, makes it clear
exactly what this test was added for.

Other than that, patch and test look good to me.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?50122>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/