[Octave-bug-tracker] [bug #50412] fixes loading of .xlsm files in pkg io-2.4.5

[anonymous]

URL:
  <http://savannah.gnu.org/bugs/?50412>

                 Summary: fixes loading of .xlsm files in pkg io-2.4.5
                 Project: GNU Octave
            Submitted by: None
            Submitted on: Mon 27 Feb 2017 03:34:01 PM UTC
                Category: Libraries
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: None
                  Status: None
             Assigned to: None
         Originator Name: Owen Kelly
        Originator Email: address@hidden
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 4.2.1
        Operating System: Any

    _______________________________________________________

Details:

Issue 1:

There is an execution path of packages\io-2.4.5\xlswrite.m that throws an
error with variable r_extnd not defined.

Solution 1: 
   Add line 129: 
     r_extnd = 0;


Issue 2:

The regex to recognize file extension (line 186) does not capture '.xlsm'.
Note, in the solution, the order of patterns is important; .xls should be last
in the group of .xls? patterns.

Solution 2:

In file packages\io-2.4.5\xlsopen.m
   Change line 186 to
     [sfxpos, ~, ~, ext] = regexpi (filename,
'(\.xlsm|\.xlsb|\.xlsx|\.xls|\.gnumeric|\.ods|\.csv)');
   from
     [sfxpos, ~, ~, ext] = regexpi (filename,
'(\.xlsx?|\.gnumeric|\.ods|\.csv)');



Issue 3: 

Files of type .xlsm are not recognized by getnmranges.m.
After the name is recognized, the xlsm files appear to load successfully,
though I have not reviewed closely.

Solution 3:

In file packages\io-2.4.5\private\__OCT_getnmranges__.m
   Change line 29 to
       case {".xlsx", ".xlsm"}
   from
       case ".xlsx"






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?50412>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/