[Octave-bug-tracker] [bug #50493] datetick crashes on certain date ranges

[Lars Kindermann]

URL:
  <http://savannah.gnu.org/bugs/?50493>

                 Summary: datetick crashes on certain date ranges
                 Project: GNU Octave
            Submitted by: larskindermann
            Submitted on: Wed 08 Mar 2017 12:06:56 PM UTC
                Category: Plotting
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Unexpected Error
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: Any

    _______________________________________________________

Details:

The datetick command crashes if the date range is between 3 and about 3 1/2
month.



t=datenum([2017 01 01]):datenum([2017 04 1]);
plot(t,t)
datetick x

error: monthstart(1.5): subscripts must be either integers 1 to (2^63)-1 or
logicals
error: called from
    datenum at line 154 column 9
    datetick>__datetick__ at line 222 column 15
    datetick at line 56 column 5



This results from an attempt in datetick to plot ticks in 1/2 month distance
and the datenum function won't accept fractional values for the month.

I have attached a patch for datetick.m that fixes this problem:



# HG changeset patch
# User larskindermann
# Date 1488974463 -3600
#      Wed Mar 08 13:01:03 2017 +0100
# Node ID 3d6aca89d3bae2171379d108669fe5d7c1d02940
# Parent  4890b1c4a6bd53f409f994d327054ddd61a5e548
fix range bug in datetick.m

diff -r 4890b1c4a6bd -r 3d6aca89d3ba scripts/plot/appearance/datetick.m
--- a/scripts/plot/appearance/datetick.m        Tue Mar 07 08:15:24 2017 -0800
+++ b/scripts/plot/appearance/datetick.m        Wed Mar 08 13:01:03 2017 +0100
@@ -219,9 +219,10 @@
         minmonth = ifelse (minmonth == 0, 1, minmonth);
         maxmonth = sep * ceil (maxmonth / sep);
         rangemonth = (minmonth:sep:maxmonth)';
+        tickdays = ones(size (rangemonth)) + 28 * mod(rangemonth,1);
         ticks = datenum ([repmat(minyear, size(rangemonth)), ...
-                          rangemonth, ...
-                          ones(size (rangemonth))]);
+                          floor(rangemonth), ...
+                          tickdays]);
       else
         sep = __calc_tick_sep__ (minyear, maxyear);
         minyear = sep * floor (minyear / sep);






    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed 08 Mar 2017 12:06:56 PM UTC  Name: datetick.diff  Size: 1kB   By:
larskindermann

<http://savannah.gnu.org/bugs/download.php?file_id=39939>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?50493>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/