octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #50708] image package: add demosaic.m


From: Avinoam Kalma
Subject: [Octave-bug-tracker] [bug #50708] image package: add demosaic.m
Date: Mon, 3 Apr 2017 16:12:57 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Update of bug #50708 (project octave):

                 Summary: image package: add demosiac.m => image package: add
demosaic.m

    _______________________________________________________

Follow-up Comment #3:

Thanks for contributing this function.

However, there are few problems:
* The function name should be demosaic, as Hartmut commented in comment#2.
* Octave coding should use # and not % for comments.
* The string comparison should use strcmp and not ==.
* Some of the input checks are wrong. 
* Matlab allows only types of uint8, uint16 and uint32.
* Matlab allows minimal image size of 5x5.
* Matlab does not demand  even sized images.
* Matlab does not use bilinear interpolation but Malvar-He-Cutler demosaicing,
which is better (see
[https://www.microsoft.com/en-us/research/wp-content/uploads/2016/02/Demosaicing_ICASSP04.pdf]
or [http://www.ipol.im/pub/art/2011/g_mhcd/article.pdf]).
This method uses a 5x5 filter (that's the reason for the minimal size)
* There are no builtin self tests, as Carnë noted in comment#1.

Attached a new version which (try to) fix the first 6 items.


(file #40250)
    _______________________________________________________

Additional Item Attachment:

File name: demosaic.m                     Size:2 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?50708>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]