[Octave-bug-tracker] [bug #51310] firls.m modification to include all 4 FIR types, Hilbert transformer, and differentiator

[Nicholas Jankowski]

Follow-up Comment #3, bug #51310 (project octave):

Mike? thoughts on either (2) or (3)?

Unless we really want to force compatibility here, my suggestion on (3) is to
have the function produce a warning when the non-compatibile event occurs,
document it in the help text, and move on.  One alternative would be would be
to provide an _optional_ compatibility flag so that it forces compatible
behavior. (i.e., if (matlab_compatible) n++ )

See the help text for the currently released version of cov [1] for an example
of such documentation.

Then, for (2) you said you were benchmarking against Maxima before. Can you
provide a couple examples here showing that what you're referring to on your
code produces a more accurate filter? I'm not disputing this, but having it
documented here would be enough justification in my opinion to leave it as is
and move on.  If someone later has a better idea for the algorithm they could
always propose an update. What's more important is to be confident your
version doesn't produce any wildly incorrect answers (for odd inputs, corner
cases, etc.). I think another note in the help would be useful stating that
because of algorithmic differences the output may not exactly match Matlab's
but still meets "the definition of 'good' according to _??__". 

Then if format/function are good, seems it's about ready to propose rolling it
up into a patch for the signal package.

[1] https://octave.sourceforge.io/octave/function/cov.html

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51310>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/