[Octave-bug-tracker] [bug #51766] [octave forge] (interval) pdftocairo build rule is not safe for parallel make

[Mike Miller]

URL:
  <http://savannah.gnu.org/bugs/?51766>

                 Summary: [octave forge] (interval) pdftocairo build rule is
not safe for parallel make
                 Project: GNU Octave
            Submitted by: mtmiller
            Submitted on: Wed 16 Aug 2017 10:42:42 AM PDT
                Category: Octave Forge Package
                Severity: 2 - Minor
                Priority: 5 - Normal
              Item Group: Build Failure
                  Status: Patch Submitted
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: other
        Operating System: GNU/Linux

    _______________________________________________________

Details:

When running "make -j8 dist", the build rule that calls pdftocairo is not
thread-safe since it uses the same intermediate file name for each command.
This file needs to be either randomized or based on the input argument.

The following change fixes this for me


diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -192,8 +192,8 @@ endif
 $(GENERATED_IMAGE_DIR)/%.svg.png: $(GENERATED_IMAGE_DIR)/%.svg.pdf
        @# The output of pdftocairo has a much better quality
        @# compared to the output from inkscape --export-png.
-       @pdftocairo -png -singlefile -transp -r 120 "$<"
"$(BUILD_DIR)/cairo.tmp"
-       @mv "$(BUILD_DIR)/cairo.tmp.png" "$@"
+       @pdftocairo -png -singlefile -transp -r 120 "$<"
"$(BUILD_DIR)/$*.tmp"
+       @mv "$(BUILD_DIR)/$*.tmp.png" "$@"
 $(GENERATED_IMAGE_DIR)/%.svg.eps $(GENERATED_IMAGE_DIR)/%.svg.pdf:
doc/image/%.svg | $(GENERATED_IMAGE_DIR)
        @echo "Compiling $< ..."
        @inkscape --without-gui \





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51766>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/