octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #51954] exit in Command Window hangs GUI


From: Dan Sebald
Subject: [Octave-bug-tracker] [bug #51954] exit in Command Window hangs GUI
Date: Wed, 6 Sep 2017 18:01:06 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0

Follow-up Comment #6, bug #51954 (project octave):

Regarding this comment:


variable_editor::~variable_editor (void)
{
  // FIXME: This doesn't work yet.
  //
  //  delete m_main;
  //  delete m_tool_bar;
  //  delete m_tab_widget;
}


The m_tool_bar and m_tab_widget look to be created with a non-NULL parent,
i.e.,


    m_main (new QMainWindow ()),
    m_tool_bar (new QToolBar (m_main)),
    m_tab_widget (new QTabWidget (m_main)),


QMainWindow is probably a container class, meaning that it takes
responsibility of cleaning up all the objects that it holds.  Calling delete
on m_tool_bar and m_tab_widget means delete is most likely done twice, the
second time being an error.

Whether delete needs to be called on m_main, isn't so clear.  (Notice it has
no parent passed into the constructor.)  Should look if that is being cleaned
up indirectly somehow.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51954>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]