[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #52024] Memory issue using File->Close from FL
|
From: |
Pantxo Diribarne |
|
Subject: |
[Octave-bug-tracker] [bug #52024] Memory issue using File->Close from FLTK figure window |
|
Date: |
Wed, 20 Sep 2017 10:45:21 -0400 (EDT) |
|
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 |
Follow-up Comment #2, bug #52024 (project octave):
If I do the following change I don't see the heap-use-after-free anymore:
diff -r 83cd00e6582b libinterp/corefcn/graphics.cc
--- a/libinterp/corefcn/graphics.cc Wed Sep 20 16:07:51 2017 +0200
+++ b/libinterp/corefcn/graphics.cc Wed Sep 20 16:42:06 2017 +0200
@@ -1778,7 +1778,7 @@
// We are executing the callback function associated with this
// callback property. When set to true, we avoid recursive calls to
// callback routines.
- frame.protect_var (executing);
+ //frame.protect_var (executing);
// We are executing a callback function, so allow handles that have
// their handlevisibility property set to "callback" to be visible.
The issue here is that "executing" is an attribute of the callback_property
object which will be destroyed by the callback execution and will thus be
already freed when the unwind_protect object tries to restore its value.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?52024>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/