octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #52090] default values for missing GUI setting


From: Mike Miller
Subject: [Octave-bug-tracker] [bug #52090] default values for missing GUI settings out of sync between settings dialog and actual behavior
Date: Fri, 22 Sep 2017 13:20:47 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

Follow-up Comment #3, bug #52090 (project octave):

I think the most important issue to address first is just to make sure that
the defaults in settings-dialog.cc agree with those used elsewhere. For
example


$ grep -Hn 'value.*connection.*toBool' libgui/src/*.cc
libgui/src/main-window.cc:193:        = settings->value
("news/allow_web_connection", true).toBool ();
libgui/src/main-window.cc:518:       ? settings->value
("news/allow_web_connection", true).toBool ()
libgui/src/settings-dialog.cc:511:  ui->checkbox_allow_web_connect->setChecked
(settings->value ("news/allow_web_connection", false).toBool ());


These should all be false.

Whether that means a refactoring of where these values or functions to wrap
how they are retrieved with their default values, up to you if you want to
look at that.

Secondarily, if you think we can minimize or eliminate entirely the
default-qt-settings file, that's a bonus.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52090>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]