octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #52169] gnuplot graphics toolkit tick color do


From: Dan Sebald
Subject: [Octave-bug-tracker] [bug #52169] gnuplot graphics toolkit tick color doesn't match axis color
Date: Fri, 6 Oct 2017 16:23:12 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

Follow-up Comment #2, bug #52169 (project octave):

Since this is a regression, I've searched through all the patches I have here
(I always copy my patches to a local subdirectory before posting).  The
closest related patch (not sure it was ever pushed though) seems to be the
following from djs2017mar10


diff --git a/scripts/plot/util/private/__gnuplot_draw_axes__.m
b/scripts/plot/util/private/__gnuplot_draw_axes__.m
--- a/scripts/plot/util/private/__gnuplot_draw_axes__.m
+++ b/scripts/plot/util/private/__gnuplot_draw_axes__.m
@@ -2314,24 +2334,14 @@ function do_tics_1 (ticmode, tics, mtics
   endif
   colorspec = get_text_colorspec (color);
   fprintf (plot_stream, "set format %s \"%s\";\n", ax, fmt);
-  if (strcmp (ticmode, "manual"))
-    if (isempty (tics))
-      fprintf (plot_stream, "unset %stics;\nunset m%stics;\n", ax, ax);
-      return
-    endif
-    fprintf (plot_stream, "set %stics %s %s %s %s (", ax, tickdir,
-             ticklength, axispos, mirror);
-    fprintf (plot_stream, " %.15g,", tics(1:end-1));
-    fprintf (plot_stream, " %.15g) %s;\n", tics(end), fontspec);
+  if (strcmp (ticmode, "manual") && isempty (tics))
+    fprintf (plot_stream, "unset %stics;\nunset m%stics;\n", ax, ax);
+    return
   else
-    fprintf (plot_stream, "set %stics %s %s %s %s %s %s;\n", ax,
-             tickdir, ticklength, axispos, mirror, colorspec, fontspec);
-  endif
-  if (strcmp (labelmode, "manual"))
     k = 1;
     ntics = numel (tics);
     nlabels = numel (labels);
-    fprintf (plot_stream, "set %stics add %s %s %s %s (", ax,
+    fprintf (plot_stream, "set %stics %s %s %s %s (", ax,
              tickdir, ticklength, axispos, mirror);
     labels = strrep (labels, "%", "%%");
     for i = 1:ntics


That date would be after the July 2016 timeframe.  Notice how the re is one
fprintf() removed that uses colorspec, but the one that is retained doesn't
have the color spec.  Again, not sure if this was ever applied, or exactly
what happened.  But this would be a good starting point for investigating
where the issue might be.

I'll look at this and come up with a changeset.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52169>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]