octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #52484] csvread/dlmread should support or dete


From: Dan Sebald
Subject: [Octave-bug-tracker] [bug #52484] csvread/dlmread should support or detect newline option
Date: Thu, 23 Nov 2017 04:48:02 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

Follow-up Comment #5, bug #52484 (project octave):

Oh, that's right.  I'm recalling now.  Thanks.

That bug refers to this bug:

https://savannah.gnu.org/bugs/?51871

which I think we left off with Rik wondering what parts of his patch could
still be used.  I didn't write an actual patch (which is what I was searching
for), just wrote some comments with regard to Rik's modification.  My feeling
was that all of it could be reused if we just wrote a custom getline-like
routine that handles all three EOL symbols.

I was also thinking that I could speed that getline-like routine up by not
wiping the referenced string clean with each new line read, but instead reuse
the string placing an EOL character in the appropriate location of the string
or expanding the string if the line gets longer in the file.  I've a feeling
that might reduce that load time a good fraction because there won't be so
much clearing/initializing strings with each line in the file.

Rik, should I work a bit on your proposed changeset at the link above and
create another version?  It might be easier doing what I have in mind than
explaining it to you so that you may update the patch.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52484>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]