octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #49053] figure scaling issue with Qt 5 on macO


From: Markus Mützel
Subject: [Octave-bug-tracker] [bug #49053] figure scaling issue with Qt 5 on macOS with Retina / HiDPI scaling
Date: Thu, 18 Jan 2018 14:50:27 -0500 (EST)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

Follow-up Comment #40, bug #49053 (project octave):

The patch from comment #38 compiled just fine with Qt4 on Ubuntu 17.10.
However with Qt5, I get this compile error:

  CXX      libgui/graphics/libgui_graphics_libgui_graphics_la-GLCanvas.lo
../libgui/graphics/GLCanvas.cc:36:12: fatal error: QApplication.h: No such
file or directory
   #include <QApplication.h>
            ^~~~~~~~~~~~~~~~
compilation terminated.
Makefile:16539: recipe for target
'libgui/graphics/libgui_graphics_libgui_graphics_la-GLCanvas.lo' failed
make[2]: *** [libgui/graphics/libgui_graphics_libgui_graphics_la-GLCanvas.lo]
Error 1
make[2]: *** Waiting for unfinished jobs....


Apart from that you should break some very long lines in your patch. Usually,
we break lines at 80 characters.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?49053>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]