[Octave-bug-tracker] [bug #52933] [octave-forge] (image) regionprops Perimeter returns Matlab incompatible results

[Hartmut]

Follow-up Comment #7, bug #52933 (project octave):

I have had a closer look at your code proposal from comment #6. 
My comments:
* The single code line "no" was probably for debug purposes and should be
deleted.
* The definition of CHAIN_CODE might be better positioned at a later time in
the code, but this might be a question of taste.
* Why does the check np==2 check for single pixels? Shouldn't this be np==1?
* Could you take the previous code, to create the new property "perimeterold"?
All the existing tests for perimeter should then also be turned into tests for
perimeterold (and checked if they are still Matlab compatible, but they should
be.)
* Could you add new tests for the new perimeter property? I think you could
re-use the existing test code, just change the expected results into the new
Matlab results.
* I have run your code on the example from bug #52926 and there is one
discrepancy: When using connectivity 4, the perimeter value for the last
(third) region is 6.9220 with your new code, but the Matlab result is cited as
7.0130 there. Does this hint you to a persisting code incompatibility?
* Could you wrap your new code into a changeset? I think this helps Carne
testing it.
Thanks for digging into this.



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52933>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/