[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #50198] Calling "error" from the GUI thread le
From: |
Pantxo Diribarne |
Subject: |
[Octave-bug-tracker] [bug #50198] Calling "error" from the GUI thread lead to segfaults |
Date: |
Fri, 2 Feb 2018 07:17:11 -0500 (EST) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 |
Follow-up Comment #10, bug #50198 (project octave):
>> I still think it's odd to have "parse error" for any exception thrown over
octave_link, but that is a small price for stopping segfaults.
It is also odd to have the prompt, "octave:7>" displayed in the middle of an
error message. Ideally we would directly call "error" from the interpreter
thread. For this we could have "error" throw a special exception (say
gui_error_exception, in which arguments would be stored) when it is not ran
from the interpreter thread, instead of displaying a message before throwing
execution_exception. Then octave_link::post_exception could check the
exception type:
* gui_error_exception: retrieve the arguments and post error_callback, which
would run "error" with original arguments
* foreign exception: post rethrow_exception_callback
In any event we can't avoid the try/catch block around suspicious code path if
we want to handle foreign exceptions (see e.g. pipe execution error in bug
#53010).
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?50198>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/