octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #53023] Marker symbols not fully drawn for som


From: Rik
Subject: [Octave-bug-tracker] [bug #53023] Marker symbols not fully drawn for some output formats
Date: Mon, 5 Feb 2018 17:42:42 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

Update of bug #53023 (project octave):

                  Status:         Patch Submitted => Patch Reviewed         

    _______________________________________________________

Follow-up Comment #22:

This looks good.  I have two items to check before you commit it.

1) Shouldn't the marker '.' be included in the list of rounded cornermarkers? 
It is drawn the same way that 'o' is and that marker is in the rounded list.

2) There is a cut and paste error.  The letter 'p' should be checked for to
indicate pentagram.  Instead the letter 'h' is being checked twice.


+      if (m == "o" || m == "v" || m == "^" || m == ">" || m == "<" || m ==
"h"
+          || m == "hexagram" || m == "h" || m == "pentagram")
+        {
+          set_linejoin ("round");
+          set_linecap ("round");
+        }
+      else
+        {
+          set_linejoin ("miter");
+          set_linecap ("square");
+        }




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53023>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]