[Octave-bug-tracker] [bug #36003] misleading error for assignment to empty structure

[Rik]

Update of bug #36003 (project octave):

                  Status:               Confirmed => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #5:

I checked in the changeset here
(http://hg.savannah.gnu.org/hgweb/octave/rev/2ce26c4cb323).

Since this was from a new contributor, I'll document the changes I made to the
patch before committing.

1) In order not to violate Matlab copyright I did not copy their error message
verbatim.  Besides, I still felt it was a little unclear.  Instead, I used
this,


  error ("invalid dot name structure assignment because the structure array is
empty.  Specify a subscript on the structure array to resolve.");


2) The functions in errwarn.h and errwarn.cc have no logical order so they are
listed in alphabetical order as being the least bad organizational principle. 
I put your new function in to correct alphabetic order in both files.

3) When using 'make check' to run the test suite I discovered that there was
now a test failure.  The failure was due to the fact that the test was looking
specifically for the old error message.  I changed the test to match the new
message and now the test suite is passing without regressions.

@Joe: If you would like to be listed in the Octave manual as a contributor to
Octave just let me know.  The list of contributors appears in the preface
section of the manual.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?36003>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/