[Octave-bug-tracker] [bug #53046] Variable Editor: feature request to make multiple tables visible at once.

[Dan Sebald]

Follow-up Comment #26, bug #53046 (project octave):

I'll let you think about focus since you are working on that, but to reiterate
what I think you are saying is that rather than having everything hooked to
the one signal focusChanged(), there might be a sort of fanning out at each
level.  Such a thing could be done at the octave_dock_widget level, e.g.


focusChange -> octave_dock_widget_slot
if (octave_dock_widget is active)
  octave_dock_widget_signal -> variable_dock_widget


in which case all that needs to be done is change the connection of the
variable_dock_widget.

Again, I'll let you work out the general theme, but looking at some of the
code around that changeset, you might achieve some of that using already
existing Qt methods.  Have a look at something like this:


findChildren<octave_dock_widget *> (QString (), Qt::FindDirectChildrenOnly);


instead of


main_window::dock_widget_list (void)


(see http://doc.qt.io/qt-5/qobject.html#findChildren) and 


if (new_widget == focusWidget ())


instead of that code that looks at all the objects checking if they are
ancestors.  The QObject::focusWidget() effectively does that
(QObject::focusWidget() is not the same as the QApplication::focusWidget(),
see http://doc.qt.io/qt-5/qwidget.html#focusWidget)

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53046>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/