[Octave-bug-tracker] [bug #53211] detrend functionality missing for complex values

[anonymous]

URL:
  <http://savannah.gnu.org/bugs/?53211>

                 Summary: detrend functionality missing for complex values
                 Project: GNU Octave
            Submitted by: None
            Submitted on: Fri 23 Feb 2018 08:24:02 PM UTC
                Category: Octave Function
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Matlab Compatibility
                  Status: None
             Assigned to: None
         Originator Name: Hans Reiser
        Originator Email: address@hidden
             Open/Closed: Open
         Discussion Lock: Any
                 Release: 4.2.1
        Operating System: Any

    _______________________________________________________

Details:

Matlab's detrend() function works fine for arrays of complex values, whereas
code working fine with Matlab fails in Octave with the error "detrend: first
input argument must be a real vector or matrix". 

It seems to me that the function's actual functionality would be fine for
complex arguments as well, so the following patch that simply adjusts the
argument check seems to fix the problem and enhance Matlab compatibility:

--- /tmp/detrend.m      2018-02-23 21:18:07.000000000 +0100
+++ share/octave/4.2.1/m/signal/detrend.m       2018-02-23 21:17:55.000000000 
+0100
@@ -39,7 +39,7 @@
 
 function y = detrend (x, p = 1)
 
-  if (nargin > 0 && isreal (x) && ndims (x) <= 2)
+  if (nargin > 0 && (iscomplex(x)||isreal (x)) && ndims (x) <= 2)
     ## Check p
     if (ischar (p) && strcmpi (p, "constant"))
       p = 0;
@@ -49,7 +49,7 @@
       error ("detrend: second input argument must be 'constant', 'linear' or
a positive integer");
     endif
   else
-    error ("detrend: first input argument must be a real vector or matrix");
+    error ("detrend: first input argument must be a real (or complex) vector
or matrix");
   endif
 
   [m, n] = size (x);





    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53211>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/