[Octave-bug-tracker] [bug #53278] Cannot build Octave

[Rik]

Update of bug #53278 (project octave):

                  Status:            Works For Me => In Progress            

    _______________________________________________________

Follow-up Comment #6:

Adding Pantxo to the CC list.  The trouble seems to be this section of
m4/acinclude.m4:


    if test -n "$OPENGL_LIBS"; then
      OCTAVE_CHECK_QT_OPENGL_OK([build_qt_graphics=yes],
        [warn_qt_opengl="Qt does not work with the OpenGL libs (GL and GLU);
disabling OpenGL graphics with Qt GUI"])

      if test $build_qt_graphics = yes; then
        OCTAVE_CHECK_QT_OPENGL_OFFSCREEN_OK([have_qt_opengl_offscreen=yes])
        AC_DEFINE(HAVE_QT_GRAPHICS, 1, [Define to 1 if Qt works with OpenGL
libs (GL and GLU)])
      fi
    fi


>From your configure log, it is possible to have QOFFSCREENSURFACE, but for it
not to work in combination with OpenGL.  The m4 macro
OCTAVE_CHECK_QT_OPENGL_OFFSCREEN is set up quite traditionally to execute the
first code section if the result of tests is true, and the second code section
of tests if the result is false.  But the way the macro is invoked, there is
only an action for a positive result of the test.

There are multiple ways to resolve this.  One would be to AC_DEFINE some other
constant, rather than HAVE_QOFFSCREENSURFACE, when configure passes all tests
necessary to use offscreen rendering.  Then the actual C++ code should be
modified to test for this constant, rather than HAVE_QOFFSCREENSURFACE which
can be present even though not usable.

Also, I would re-order the AC_DEFINE(HAVE_QT_GRAPHICS) to occur before
OCTAVE_CHECK_QT_OPENGL_OFFSCREEN_OK.  Having it follow the test makes it look
like it is dependent on the results, which it isn't.



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53278>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/