[Octave-bug-tracker] [bug #51310] [octave forge] (signal) firls.m modification to include all 4 FIR types, Hilbert transformer, and differentiator

[Vlad]

Follow-up Comment #10, bug #51310 (project octave):

> 1. This function is basically a rewrite, there's no need to keep the
Copyright line from the original function there is basically no original code
left.
Even if my whole contribution to a project would be one byte, I would be
starting a bloody and very messy war if someone decided to brush it off. I
don't know if Quentin Spencer behaves like me, but I'd rather not ignore his
work, so I would keep that line, if it's alright with you.

> 2. Please don't use narginchk, use the original form that calls the
print_usage function.
> 3. The entire body of the function (between "function" and "endfunction")
should be indented by 2 spaces.
Alright, fixed, uploaded.

> I haven't read enough here about the reason for the "MatlabCompat" option,
but I would rather it be compatible by default and not print a message when it
does this compatible operation.
It defaults to Matlab compatibility. If one does not desire to be so, the
extra argument 'no', or 'n', can be added, and then it will behave the
modified way.

> I gather that you find this compatibility a little distasteful.
I have my reasons, sure, but I'd rather wait until my world domination is
complete before I can impose my will unto the rest. My apologies for the wait.

(file #43611)
    _______________________________________________________

Additional Item Attachment:

File name: firls.m                        Size:39 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?51310>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/