[Octave-bug-tracker] [bug #53378] Octave date function doesn't provide any error when provided arguments where MATLAB does

[Mike Miller]

Update of bug #53378 (project octave):

                  Status:          Patch Reviewed => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #6:

I adapted your latest change and pushed it on the stable branch. Thank you for
your contribution to Octave!

Functionally your patch was absolutely correct. But stylistically, I think you
should study the Octave code base and our codind style guidelines a little
more. Please review the changes that I made from the patch you provided. You
were still missing a blank line after the input validation if-endif block. We
typically label tests that test input validation "## Test input validation".
The %!error call does not need an extra set of parentheses. And I reworded the
commit message to resemble other commit messages of this type as I tried to
point out to you.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53378>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/