[Octave-bug-tracker] [bug #53438] tests: rand.cc: 5 failing tests on i686 due to tolerance changes

[Mike Miller]

URL:
  <http://savannah.gnu.org/bugs/?53438>

                 Summary: tests: rand.cc: 5 failing tests on i686 due to
tolerance changes
                 Project: GNU Octave
            Submitted by: mtmiller
            Submitted on: Fri 23 Mar 2018 12:18:17 AM PDT
                Category: Test Suite
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Inaccurate Result
                  Status: Patch Submitted
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
                 Release: dev
        Operating System: GNU/Linux

    _______________________________________________________

Details:

In testing Octave built for i686, I am seeing 5 test failures in rand.cc. The
5 tests that are failing are reproducible because they are labeled "Test a
known fixed state". I believe these test failures were introduced with
changeset 8bb0251fcfde
(https://hg.savannah.gnu.org/hgweb/octave/rev/8bb0251fcfde), which tightened
the tolerances on many of the tests.

The attached patch fixes all test failures for me on i686 by loosening the
tolerances again, not as loose as they used to be.

Cc Rik who last editing these tests, does it make sense to you to bump the
tolerances up a bit to allow for what I'm seeing on i686?

I've cut out the important lines from the test log below:


ASSERT errors for:  assert (randn (1, 6),[-2.666521678978671,
-0.7381719971724564, 1.507903992673601, 0.6019427189162239,
-0.450661261143348, -0.7054431351574116],eps)
    (2)        -0.73817     -0.73817     Abs err 8.8818e-16 exceeds tol
2.2204e-16 by 7e-16
    (3)         1.5079       1.5079      Abs err 4.4409e-16 exceeds tol
2.2204e-16 by 2e-16
    (4)        0.60194      0.60194      Abs err 2.9976e-15 exceeds tol
2.2204e-16 by 3e-15
    (6)        -0.70544     -0.70544     Abs err 1.3323e-15 exceeds tol
2.2204e-16 by 1e-15
ASSERT errors for:  assert (randg (0.95, 1, 6),[3.099382433255327,
0.3974529788871218, 0.644367450750855, 1.143261091802246, 1.964111762696822,
0.04011915547957939],2 * eps)
    (1)         3.0994       3.0994      Abs err 8.8818e-16 exceeds tol
4.4409e-16 by 4e-16
    (3)        0.64437      0.64437      Abs err 2.5535e-15 exceeds tol
4.4409e-16 by 2e-15
    (4)         1.1433       1.1433      Abs err 1.1102e-15 exceeds tol
4.4409e-16 by 7e-16
ASSERT errors for:  assert (randg (1, 1, 6),[0.2273389379645993,
1.288822625058359, 0.2406335209340746, 1.218869553370733, 1.024649860162554,
0.09631230343599533],4 * eps)
    (2)         1.2888       1.2888      Abs err 3.9968e-15 exceeds tol
8.8818e-16 by 3e-15
    (4)         1.2189       1.2189      Abs err 8.8818e-15 exceeds tol
8.8818e-16 by 8e-15
ASSERT errors for:  assert (randg (10, 1, 6),[3.520369644331133,
15.15369864472106, 8.332112081991205, 8.406211067432674, 11.81193475187611,
10.88792728177059],16 * eps)
    (2)        15.1537      15.1537      Abs err 7.1054e-15 exceeds tol
3.5527e-15 by 4e-15
    (4)        8.40621      8.40621      Abs err 1.2434e-14 exceeds tol
3.5527e-15 by 9e-15
    (5)        11.8119      11.8119      Abs err 5.3291e-15 exceeds tol
3.5527e-15 by 2e-15
ASSERT errors for:  assert (randg (100, 1, 6),[75.34570255262264,
115.4911985594699, 95.23493031356388, 95.48926019250911, 106.2397448229803,
103.4813150404118],132 * eps)
    (4)        95.48926     95.48926     Abs err 5.6843e-14 exceeds tol
2.931e-14 by 3e-14
    (6)        103.4813     103.4813     Abs err 4.2633e-14 exceeds tol
2.931e-14 by 1e-14






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53438>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/