[Octave-bug-tracker] [bug #53537] main_window::focus_changed() routine should be improved

[Dan Sebald]

Follow-up Comment #4, bug #53537 (project octave):

I'm attaching a changeset that simplifies the routine by leaving out code and
no real change in logic.  *There's still a bug*, which I will describe in a
follow-up post.

1) I find the outer loop that looks at next widget in focus change to be
unnecessary.

2) The m_editor_window is a pointer to a file_editor_interface, and


namespace octave
{
  class file_editor_interface : public octave_dock_widget


so there is no need to cast m_editor_window.

3) I don't see what the second expression in (dock || m_active_dock !=
edit_dock_widget) adds, so removed it.  I can't think of a corner case, but
maybe there is one.

(file #43765)
    _______________________________________________________

Additional Item Attachment:

File name: octave-main_window_focus_change_cleanup-djs2018apr01.patch Size:3
KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53537>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/