[Octave-bug-tracker] [bug #53557] pkg.tst should not write to the test directory or the user's home directory

[Mike Miller]

Update of bug #53557 (project octave):

                  Status:                   Fixed => Confirmed              
             Open/Closed:                  Closed => Open                   

    _______________________________________________________

Follow-up Comment #6:

I just built 2fcd829a6878, and this doesn't look fixed to me. I get four test
failures and plenty of messages about failure to write to HOME:


$ HOME=/nonexistent ./run-octave --no-history --norc --silent --eval
"__octave_config_info__ hg_id"
ans = 2fcd829a6878
$ HOME=/nonexistent ./run-octave --no-history --norc --silent --eval "chdir
('../test/pkg'); [a,b,c,d,e,f] = test ('pkg.tst', 'quiet', stdout)"
>>>>> processing pkg.tst
***** test
 for i = 1:numel (mfile_pkg_name)
   silent_pkg_install (mfile_pkg_zip{i});
   pkg ("uninstall", mfile_pkg_name{i});
 endfor

!!!!! test failed
save: unable to open output file '/nonexistent/.octave_packages'
shared variables   scalar structure containing the fields:

    old_prefix = /nonexistent/octave
    old_archprefix = /nonexistent/octave
    prefix = /run/user/1000/tmpdir/oct-bnIcCf
    restorecfg =

onCleanup (@() pkg ("prefix", old_prefix, old_archprefix))

    rmtmpdir =

onCleanup (@() confirm_recursive_rmdir (0, "local") && rmdir (prefix, "s"))

    mfile_pkg_name =
    {
      [1,1] = mfile_basic_test
      [1,2] = mfile_minimal_test
    }

    mfile_pkg_zip =
    {
      [1,1] = /run/user/1000/tmpdir/oct-bnIcCf/mfile_basic_test.zip
      [1,2] = /run/user/1000/tmpdir/oct-bnIcCf/mfile_minimal_test.zip
    }

***** test
 for i = 1:numel (mfile_pkg_name)
   silent_pkg_install ("-local", mfile_pkg_zip{i});
   pkg ("uninstall", mfile_pkg_name{i});
 endfor
!!!!! test failed
save: unable to open output file '/nonexistent/.octave_packages'
shared variables   scalar structure containing the fields:

    old_prefix = /nonexistent/octave
    old_archprefix = /nonexistent/octave
    prefix = /run/user/1000/tmpdir/oct-bnIcCf
    restorecfg =

onCleanup (@() pkg ("prefix", old_prefix, old_archprefix))

    rmtmpdir =

onCleanup (@() confirm_recursive_rmdir (0, "local") && rmdir (prefix, "s"))

    mfile_pkg_name =
    {
      [1,1] = mfile_basic_test
      [1,2] = mfile_minimal_test
    }

    mfile_pkg_zip =
    {
      [1,1] = /run/user/1000/tmpdir/oct-bnIcCf/mfile_basic_test.zip
      [1,2] = /run/user/1000/tmpdir/oct-bnIcCf/mfile_minimal_test.zip
    }

***** test
 for i = 1:numel (mfile_pkg_name)
  name = mfile_pkg_name{i};
  silent_pkg_install ("-local", mfile_pkg_zip{i});
  unwind_protect
    pkg ("load", name);
    pkg ("unload", name);
  unwind_protect_cleanup
    pkg ("uninstall", name);
  end_unwind_protect
 endfor

!!!!! test failed
save: unable to open output file '/nonexistent/.octave_packages'
shared variables   scalar structure containing the fields:

    old_prefix = /nonexistent/octave
    old_archprefix = /nonexistent/octave
    prefix = /run/user/1000/tmpdir/oct-bnIcCf
    restorecfg =

onCleanup (@() pkg ("prefix", old_prefix, old_archprefix))

    rmtmpdir =

onCleanup (@() confirm_recursive_rmdir (0, "local") && rmdir (prefix, "s"))

    mfile_pkg_name =
    {
      [1,1] = mfile_basic_test
      [1,2] = mfile_minimal_test
    }

    mfile_pkg_zip =
    {
      [1,1] = /run/user/1000/tmpdir/oct-bnIcCf/mfile_basic_test.zip
      [1,2] = /run/user/1000/tmpdir/oct-bnIcCf/mfile_minimal_test.zip
    }

***** test
 silent_pkg_install ("-local", mfile_pkg_zip{1});
 [desc, flag] = pkg ("describe", mfile_pkg_name{1});
 ## FIXME: this only tests that the describe command runs,
 ##        not that the output is in anyway correct.
 pkg ("uninstall", mfile_pkg_name{1});
!!!!! test failed
save: unable to open output file '/nonexistent/.octave_packages'
shared variables   scalar structure containing the fields:

    old_prefix = /nonexistent/octave
    old_archprefix = /nonexistent/octave
    prefix = /run/user/1000/tmpdir/oct-bnIcCf
    restorecfg =

onCleanup (@() pkg ("prefix", old_prefix, old_archprefix))

    rmtmpdir =

onCleanup (@() confirm_recursive_rmdir (0, "local") && rmdir (prefix, "s"))

    mfile_pkg_name =
    {
      [1,1] = mfile_basic_test
      [1,2] = mfile_minimal_test
    }

    mfile_pkg_zip =
    {
      [1,1] = /run/user/1000/tmpdir/oct-bnIcCf/mfile_basic_test.zip
      [1,2] = /run/user/1000/tmpdir/oct-bnIcCf/mfile_minimal_test.zip
    }

warning: onCleanup: error caught while executing cleanup function:
pkg: cannot create prefix /nonexistent/octave: Permission denied


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53557>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/