[Octave-bug-tracker] [bug #53510] [octave forge] (io) wrong java check

[Philip Nienhuis]

Update of bug #53510 (project octave):

                  Status:         Patch Submitted => Patch Reviewed         

    _______________________________________________________

Follow-up Comment #18:

I just tested the patch and it works for me as well.
Later today I'll push it to the OF io repo.

As I figured the io package's spreadsheet scripts may need a bit of attention
for Java > 8, with Apache POI (and Java 10) I get:

Testing .xls interface POI using file io-test.xlsx...

 1. Initialize arrays.

 2. Insert first empty sheet.
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.apache.poi.util.DocumentHelper
(file:/C:/Users/philip/java/poi-ooxml-3.17.jar) to method
com.sun.org.apache.xerces.internal.util.SecurityManager.setEntityExpansionLimit(int)
WARNING: Please consider reporting this to the maintainers of
org.apache.poi.util.DocumentHelper
WARNING: Use --illegal-access=warn to enable warnings of further illegal
reflective access operations
WARNING: All illegal access operations will be denied in a future release


... that wasn't there with Java 8 so indeed some check for Java versions may
need to stay in __chk_java_sprt__.m.
But that is less urgent as the above looks like an upstream bug and anyway in
the end all io package functions seem to work correctly:

 :
Interface:          COM  POI  POI  JXL  OXS  UNO  OCT  OTK  JOD  UNO  OCT 
OCT
File type           xls  xls xlsx  xls  xls  xls xlsx  ods  ods  ods  ods
gnumeric
Numeric array p.1:   +    +    +    +    +    +    +    +    +    +    +    +
Numeric array p.2:   +    +    +    +    +    +    +    +    +    +    +    +
Numeric array p.3:   +    +    +    +    +    +    +    +    +    +    +    +
Numeric array p.4:   +    +    +    +    +    +    +    +    +    +    +    +
Cellstr array p.1:   +    +    +    +    +    +    +    +    +    +    +    +
Cellstr array p.2:   +    +    +    +    +    +    +    +    +    +    +    +
 ...special chars:   +    +    +    +    +    +    +    +    +    +    +    +
Boolean value    :   +    +    +    +    +    o    +    +    +    o    +    +
Formula read back:   +    +    +    +    +    +    +    +    +    +    +    +
  +  = correct result returned
  o  = partly correct (e.g., double rather than logical)
  -  = erroneous or no result.


Thanks Mike and Markus for the patches.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53510>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/