[Octave-bug-tracker] [bug #53443] Compile warning when casting QVariant to (QWidget *)

[Dan Sebald]

Follow-up Comment #24, bug #53443 (project octave):

Here's a proposed patch for default that gets rid of the need for the
tab_to_font() routine by using the strategy that brings "focus_command_window"
to the front by utilizing the focusInEvent() virtual function for reusability.
 It's probably shaking the tree a bit too much for 4.4 release, but I like the
approach.  It totally eliminates the tab_to_front() code.

In the current implementation is a newly added focus() virtual function.  It
seems to me that's essentially serving the same role as focusInEvent() so I
moved the functionality of octave_dock_widget::focus(void) to
octave_dock_widget::focusInEvent(QFocusEvent *ev).  Then from there, it was
merely replacing all occurrences of focus() with Qt's setFocus() routine (the
setFocus will issue an event that makes its way to focusInEvent() if
appropriate.  I removed a few superfluous lines of code here an there as well.

(file #43863)
    _______________________________________________________

Additional Item Attachment:

File name:
octave-eliminate_focus_and_tab_to_front_functions-djs2018apr09.patch Size:12
KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53443>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/