[Octave-bug-tracker] [bug #53650] build: clang-6.0 compiler warnings

[Rik]

Follow-up Comment #5, bug #53650 (project octave):

What I was trying to do was call the empty constructor of T just once and
therefore I did it outside the call to std::count_if.  I also used const just
to emphasize that 'zero' is really a constant value that needs to be compared
to each elem.

For std::count_if, the lamda function should be inlined, so no function
calling overhead, but it will still be called nel times.  I don't want to call
the constructor of T nel times.  Now, since this is a matrix class it is
likely that T is a POD type in which case the constructor is trivial.  But
maybe T is a complex number for which there is still some overhead in calling
the constructor.

If anything, it might be better to define the capture as capture by reference
with


[&zero]


Currently it is passing zero via a copy mechanism which might be calling the
copy constructor of T which seems like unnecessary work.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53650>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/